owenowenisme opened a new pull request, #1522:
URL: https://github.com/apache/polaris/pull/1522
<!--
Possible security vulnerabilities: STOP here and contact
secur...@apache.org instead!
Please update the title of the PR with a meaningful message - do not
leave it "empty" or "generated"
Please update this summary field:
The summary should cover these topics, if applicable:
* the motivation for the change
* a description of the status quo, for example the current behavior
* the desired behavior
* etc
PR checklist:
- Do a self-review of your code before opening a pull request
- Make sure that there's good test coverage for the changes included in
this PR
- Run tests locally before pushing a PR (./gradlew check)
- Code should have comments where applicable. Particularly
hard-to-understand
areas deserve good in-line documentation.
- Include changes and enhancements to the documentation (in
site/content/in-dev/unreleased)
- For Work In Progress Pull Requests, please use the Draft PR feature.
Make sure to add the information BELOW this comment.
Everything in this comment will NOT be added to the PR description.
-->
According to comment from @eric-maynard
https://github.com/apache/polaris/pull/1471#discussion_r2065710938, it is not a
good practice to use `sed ` to manipulate docker-compose.yml, so I changed to
use env var instead.
```bash
> export USER_CLIENT_ID="XXXX"
> export USER_CLIENT_SECRET="YYYY"
> docker compose -f getting-started/eclipselink/docker-compose.yml config
spark-sql
name: eclipselink
services:
polaris:
# omit
polaris-setup:
# omit
spark-sql:
command:
- /opt/spark/bin/spark-sql
- --packages
-
org.apache.iceberg:iceberg-spark-runtime-3.5_2.12:1.7.0,software.amazon.awssdk:bundle:2.28.17,software.amazon.awssdk:url-connection-client:2.28.17,org.apache.iceberg:iceberg-gcp-bundle:1.7.0,org.apache.iceberg:iceberg-azure-bundle:1.7.0
- --conf
-
spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions
- --conf
-
spark.sql.catalog.quickstart_catalog=org.apache.iceberg.spark.SparkCatalog
- --conf
- spark.sql.catalog.quickstart_catalog.type=rest
- --conf
- spark.sql.catalog.quickstart_catalog.warehouse=quickstart_catalog
- --conf
-
spark.sql.catalog.quickstart_catalog.uri=http://polaris:8181/api/catalog
- --conf
- spark.sql.catalog.quickstart_catalog.credential=XXXX:YYYY # env var
substitution works
- --conf
- spark.sql.catalog.quickstart_catalog.scope=PRINCIPAL_ROLE:ALL
- --conf
- spark.sql.defaultCatalog=quickstart_catalog
- --conf
- spark.sql.catalogImplementation=in-memory
- --conf
- spark.driver.extraJavaOptions=-Divy.cache.dir=/tmp -Divy.home=/tmp
# omit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
