adnanhemani commented on code in PR #1522: URL: https://github.com/apache/polaris/pull/1522#discussion_r2074243678
########## site/content/in-dev/unreleased/getting-started/using-polaris.md: ########## @@ -172,9 +172,8 @@ Finally, note that we include the `hadoop-aws` package here. If your table is us Replace the credentials used in the Docker container using the following code: ```shell -USER_CLIENT_ID="XXXX" -USER_CLIENT_SECRET="YYYY" -sed -i "s/^\(.*spark\.sql\.catalog\.quickstart_catalog\.credential=\).*/\1${USER_CLIENT_ID}:${USER_CLIENT_SECRET}\",/" getting-started/eclipselink/docker-compose.yml +export USER_CLIENT_ID="XXXX" Review Comment: If we are doing `.env` - let's also make sure to add it to the `.gitignore` or else we land into the same problem of users might accidentally commit their credentials using that file instead 😅 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org