jbonofre commented on code in PR #1515:
URL: https://github.com/apache/polaris/pull/1515#discussion_r2073505211
##########
quarkus/admin/src/testFixtures/java/org/apache/polaris/admintool/PostgresTestResourceLifecycleManager.java:
##########
@@ -63,7 +63,10 @@ public Map<String, String> start() {
context.containerNetworkId().ifPresent(postgres::withNetworkMode);
postgres.start();
return Map.of(
- "polaris.persistence.eclipselink.configuration-file",
createPersistenceXml().toString());
+ "polaris.persistence.type",
+ "eclipse-link",
Review Comment:
I think we can keep it for now (even deprecated) and remove when we remove
eclipselink.
##########
site/content/in-dev/unreleased/configuring-polaris-for-production.md:
##########
@@ -135,33 +135,19 @@ default, Polaris uses an in-memory metastore.
> The default in-memory metastore is not suitable for production use, as it
> will lose all data
> when the server is restarted; it is also unusable when multiple Polaris
> replicas are used.
-To use a durable metastore, you need to switch to the EclipseLink metastore,
and provide your own
-`persistence.xml` file. This file contains details of the database used for
metastore management and
-the connection settings. For more information, refer to the [metastore
documentation]({{% ref
-"metastores" %}}).
+To use a durable metastore, you need to switch to the Relational JDBC backed
metastore
-Then, configure Polaris to use your metastore by setting the following
properties:
+Configure the `polaris.persistence` section in your Polaris configuration file
+(`application.properties`) as follows:
Review Comment:
In another PR, I proposed to introduce a "user facing" configuration (it's
very easy to do that with Quarkus) and it's always possible to override via env
variables or config maps on k8s.
Short term in this PR, I would recommend to document the env variable use,
and if you think it makes sense I can revive my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
