singhpk234 commented on code in PR #1515:
URL: https://github.com/apache/polaris/pull/1515#discussion_r2073785085


##########
site/content/in-dev/unreleased/configuring-polaris-for-production.md:
##########
@@ -135,33 +135,19 @@ default, Polaris uses an in-memory metastore.
 > The default in-memory metastore is not suitable for production use, as it 
 > will lose all data
 > when the server is restarted; it is also unusable when multiple Polaris 
 > replicas are used.
 
-To use a durable metastore, you need to switch to the EclipseLink metastore, 
and provide your own
-`persistence.xml` file. This file contains details of the database used for 
metastore management and
-the connection settings. For more information, refer to the [metastore 
documentation]({{% ref
-"metastores" %}}).
+To use a durable metastore, you need to switch to the Relational JDBC backed 
metastore 
 
-Then, configure Polaris to use your metastore by setting the following 
properties:
+Configure the `polaris.persistence` section in your Polaris configuration file
+(`application.properties`) as follows:

Review Comment:
   documenting ENV vars makes sense to me, let me try doing that. 
   
   Re: if people like having the ability to use a local file for configuration
   
   IMHO, quarkus is quite configurable and its the deployement time they would 
need, loading confs from file will introduce these complexity like fallbacks of 
loading this file from 
[code](https://github.com/apache/polaris/blob/main/extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkPersistenceUnit.java#L129)
 never the less open the config override options for ex something configured in 
the file should override what the env specifies, by the time quarkus would get 
the handle of the file and apply configs, quarkus would have applied the confs 
to make DS ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to