eric-maynard commented on code in PR #1466:
URL: https://github.com/apache/polaris/pull/1466#discussion_r2073959622
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -234,4 +235,11 @@ public static void enforceFeatureEnabledOrThrow(
.description("If true, the policy-store endpoints are enabled")
.defaultValue(true)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<List<String>>
SUPPORTED_CATALOG_CONNECTION_TYPES =
+ PolarisConfiguration.<List<String>>builder()
+ .key("SUPPORTED_CATALOG_CONNECTION_TYPES")
+ .description("The list of supported catalog connection types for
federation")
+ .defaultValue(List.of(ConnectionType.ICEBERG_REST.name(),
ConnectionType.HADOOP.name()))
Review Comment:
It's possible and I agree with the sentiment, but I would point to the
default inclusion of FILE as a supported storage type as an important precedent
here. Following this, it seems like what we should do is call out
`SUPPORTED_CATALOG_CONNECTION_TYPES` in `configuring-polaris-for-production`.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
