eric-maynard commented on code in PR #1466:
URL: https://github.com/apache/polaris/pull/1466#discussion_r2075934454
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -234,4 +235,11 @@ public static void enforceFeatureEnabledOrThrow(
.description("If true, the policy-store endpoints are enabled")
.defaultValue(true)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<List<String>>
SUPPORTED_CATALOG_CONNECTION_TYPES =
+ PolarisConfiguration.<List<String>>builder()
+ .key("SUPPORTED_CATALOG_CONNECTION_TYPES")
+ .description("The list of supported catalog connection types for
federation")
+ .defaultValue(List.of(ConnectionType.ICEBERG_REST.name(),
ConnectionType.HADOOP.name()))
Review Comment:
For now I'll update both the FeatureConfiguration default and the
application.properties entry to only include ICEBERG_REST; when we add other
federation types we can make a case-by-case evaluation of whether we want to
enable those types by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
