singhpk234 commented on PR #1517: URL: https://github.com/apache/polaris/pull/1517#issuecomment-2855154509
Thank you @pingtimeout, Really appreciate your inputs. are you suggesting using this module from quarkus https://quarkus.io/guides/smallrye-fault-tolerance if thats the case the jdbc module was supposed to be independent of any quarkus code and Honestly i didn't knew about this functionality in first place either (thank you for pointing this out), but if i re-evaluate only because of this IMHO we should not use it. > This is a very common feature and I don't think we should reimplement it I agree with this in principal, i did evaluate options like FailSafe lib also but we don't want very sophisticated retry logic, its simple one we need with simple knobs if we want like Adaptive Retries or like callbacks i would considered using lib, but our use-case it seemed like an over kill, as bringing new lib will bring lib / notice, cve etc, hence refrained from it only for this use case. That being said, if you strongly feel about this i am happy to re evaluate and find the best path forward ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
