dimas-b commented on code in PR #1517:
URL: https://github.com/apache/polaris/pull/1517#discussion_r2075831355
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java:
##########
@@ -128,22 +143,21 @@ public <T> void executeSelectOverStream(
@Nonnull Converter<T> converterInstance,
@Nonnull Consumer<Stream<T>> consumer)
throws SQLException {
- try (Connection connection = borrowConnection();
- Statement statement = connection.createStatement();
- ResultSet resultSet = statement.executeQuery(query)) {
- ResultSetIterator<T> iterator = new ResultSetIterator<>(resultSet,
converterInstance);
- consumer.accept(iterator.toStream());
- } catch (SQLException e) {
- throw e;
- } catch (RuntimeException e) {
- if (e.getCause() instanceof SQLException) {
- throw (SQLException) e.getCause();
- } else {
- throw e;
- }
- } catch (Exception e) {
- throw new RuntimeException(e);
- }
+ withRetries(
+ () -> {
+ try (Connection connection = borrowConnection();
+ Statement statement = connection.createStatement();
+ ResultSet resultSet = statement.executeQuery(query)) {
+ ResultSetIterator<T> iterator = new ResultSetIterator<>(resultSet,
converterInstance);
+ consumer.accept(iterator.toStream());
+ return null;
+ } catch (RuntimeException e) {
+ if (e.getCause() instanceof SQLException ex) {
+ throw ex;
Review Comment:
The `RuntimeException` in this case has information about the call chain
that lead to the exception. The wrapped `SQLException` has only a sub-set of
that information. When trouble-shooting it is critical to have the most
complete data about the error.
I'd propose not to unwrap exceptions here, but take root cause exceptions
into account in the method that decides whether to retry or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
