owenowenisme commented on code in PR #1522: URL: https://github.com/apache/polaris/pull/1522#discussion_r2076801162
########## site/content/in-dev/unreleased/getting-started/using-polaris.md: ########## @@ -21,7 +21,12 @@ Title: Using Polaris type: docs weight: 400 --- - +## Setup +Define your `CLIENT_ID` & `CLIENT_SECRET` and put them in .env file for later use. Review Comment: > Can't we just keep suggesting that users `export` rather than echo things into `.env` here? > > .env is useful for when we're trying to automate things, but it seems overcomplicated to have to do all this just to set an env var: > > ``` > echo "USER_CLIENT_ID=XXXX" >> .env > echo "USER_CLIENT_SECRET=YYYY" >> .env > cd polaris > set -a > source .env > cd spark > ``` I originally is use export, so you prefer changing it back? ########## site/content/in-dev/unreleased/getting-started/using-polaris.md: ########## @@ -21,7 +21,12 @@ Title: Using Polaris type: docs weight: 400 --- - +## Setup +Define your `CLIENT_ID` & `CLIENT_SECRET` and put them in .env file for later use. Review Comment: > Can't we just keep suggesting that users `export` rather than echo things into `.env` here? > > .env is useful for when we're trying to automate things, but it seems overcomplicated to have to do all this just to set an env var: > > ``` > echo "USER_CLIENT_ID=XXXX" >> .env > echo "USER_CLIENT_SECRET=YYYY" >> .env > cd polaris > set -a > source .env > cd spark > ``` I originally used export, so you prefer changing it back? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
