adnanhemani commented on code in PR #1522: URL: https://github.com/apache/polaris/pull/1522#discussion_r2080503389
########## site/content/in-dev/unreleased/getting-started/using-polaris.md: ########## @@ -236,9 +235,6 @@ org.apache.iceberg.exceptions.ForbiddenException: Forbidden: Principal 'quicksta Replace the credentials used in the Docker container using the following code: Review Comment: ```suggestion Refresh the Docker container with the user's credentials: ``` ########## site/content/in-dev/unreleased/getting-started/using-polaris.md: ########## @@ -154,27 +161,19 @@ bin/spark-sql \ --conf spark.sql.catalog.quickstart_catalog=org.apache.iceberg.spark.SparkCatalog \ --conf spark.sql.catalog.quickstart_catalog.catalog-impl=org.apache.iceberg.rest.RESTCatalog \ --conf spark.sql.catalog.quickstart_catalog.uri=http://localhost:8181/api/catalog \ ---conf spark.sql.catalog.quickstart_catalog.credential='XXXX:YYYY' \ +--conf spark.sql.catalog.quickstart_catalog.credential='${USER_CLIENT_ID}:${USER_CLIENT_SECRET}' \ --conf spark.sql.catalog.quickstart_catalog.scope='PRINCIPAL_ROLE:ALL' \ --conf spark.sql.catalog.quickstart_catalog.token-refresh-enabled=true \ --conf spark.sql.catalog.quickstart_catalog.client.region=us-west-2 ``` -Replace `XXXX` and `YYYY` with the client ID and client secret generated when you created the `quickstart_user` principal. - Similar to the CLI commands above, this configures Spark to use the Polaris running at `localhost:8181`. If your Polaris server is running elsewhere, but sure to update the configuration appropriately. Finally, note that we include the `hadoop-aws` package here. If your table is using a different filesystem, be sure to include the appropriate dependency. #### Using Spark SQL from a Docker container Review Comment: ```suggestion #### Using Spark SQL from a Docker container Refresh the Docker container with the user's credentials: ``` ########## getting-started/eclipselink/docker-compose.yml: ########## @@ -79,7 +82,7 @@ services: --conf, "spark.sql.catalog.quickstart_catalog.type=rest", --conf, "spark.sql.catalog.quickstart_catalog.warehouse=quickstart_catalog", --conf, "spark.sql.catalog.quickstart_catalog.uri=http://polaris:8181/api/catalog";, - --conf, "spark.sql.catalog.quickstart_catalog.credential=root:s3cr3t", + --conf, "spark.sql.catalog.quickstart_catalog.credential=${USER_CLIENT_ID}:${USER_CLIENT_SECRET}", Review Comment: Given that the USER_CLIENT_ID won't be defined when the Docker Compose is first started, have you tested that this container will still start without issues? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
