adutra commented on code in PR #1572:
URL: https://github.com/apache/polaris/pull/1572#discussion_r2085258876
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusFeaturesConfiguration.java:
##########
@@ -28,6 +29,13 @@ public interface QuarkusFeaturesConfiguration extends
FeaturesConfiguration {
@Override
Map<String, String> defaults();
+ @WithParentName
Review Comment:
I _think_ this line change goes too far; basically with this annotation we
go from:
```
polaris.features.realm-overrides."my-realm"."feature"=true
```
to:
```
polaris.features."my-realm"."feature"=true
```
Which is definitely more concise, but I wonder if SmallRye will be smart
enough to "understand" that "my-realm" is a realm ID and not a feature
configuration name 🤔
@eric-maynard did you validate that this works? If it does, I'm OK to do
this but we'd need to revisit documentation + helm chart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
