eric-maynard commented on code in PR #1572:
URL: https://github.com/apache/polaris/pull/1572#discussion_r2085388307


##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusFeaturesConfiguration.java:
##########
@@ -28,6 +29,13 @@ public interface QuarkusFeaturesConfiguration extends 
FeaturesConfiguration {
   @Override
   Map<String, String> defaults();
 
+  @WithParentName

Review Comment:
   I validated that the service starts up with:
   
   ```
   polaris.features."my-realm"."INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST"=true
   ```
   
   But you're right that SmallRye may just think `my-realm` is a feature... 
actually, I don't see how it would be differentiating. Since it seems that 
don't have a test for this, let's play it safe and add the `realm-overrides` 
back in



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to