adnanhemani commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2094162149
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##########
@@ -99,4 +111,23 @@ public boolean isChildOf(StorageLocation potentialParent) {
return slashTerminatedLocation.startsWith(slashTerminatedParentLocation);
}
}
+
+ private static String scheme(String location) {
+ int schemePos = location.indexOf(':');
+ if (schemePos > 0) {
+ return location.substring(0, schemePos).toLowerCase(Locale.ROOT);
+ }
+ return null;
Review Comment:
No - this is passed early in the making of the `StorageLocation` and can, as
a result, get filesystem locations like `/var/sample/location`. This is how
we're figuring out that this is a local file path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
