eric-maynard commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2094215501
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##########
@@ -99,4 +111,23 @@ public boolean isChildOf(StorageLocation potentialParent) {
return slashTerminatedLocation.startsWith(slashTerminatedParentLocation);
}
}
+
+ private static String scheme(String location) {
+ int schemePos = location.indexOf(':');
+ if (schemePos > 0) {
+ return location.substring(0, schemePos).toLowerCase(Locale.ROOT);
+ }
+ return null;
+ }
+
+ protected String normalizePath(String path) {
Review Comment:
[Canonicalization](https://hadoop.apache.org/docs/stable/api/org/apache/hadoop/fs/FileSystem.html#canonicalizeUri-java.net.URI-)
usually means adding all the missing parts, such as the scheme and authority,
whereas [normalization](https://stackoverflow.com/a/10823859) / resolution
usually just means making a path absolute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
