dimas-b commented on code in PR #1505:
URL: https://github.com/apache/polaris/pull/1505#discussion_r2098677729
##########
service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStore.java:
##########
@@ -56,13 +59,26 @@ public DefaultConfigurationStore(
@Override
public <T> @Nullable T getConfiguration(@Nonnull PolarisCallContext ctx,
String configName) {
- String realm =
CallContext.getCurrentContext().getRealmContext().getRealmIdentifier();
+ if (realmContextInstance != null && !realmContextInstance.isUnsatisfied())
{
Review Comment:
So why not add a `Preconditions` check in a constructor? I think that would
be clearer (also make the field `final`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
