gh-yzou commented on code in PR #1505:
URL: https://github.com/apache/polaris/pull/1505#discussion_r2099046186
##########
service/common/src/main/java/org/apache/polaris/service/config/DefaultConfigurationStore.java:
##########
@@ -56,13 +59,26 @@ public DefaultConfigurationStore(
@Override
public <T> @Nullable T getConfiguration(@Nonnull PolarisCallContext ctx,
String configName) {
- String realm =
CallContext.getCurrentContext().getRealmContext().getRealmIdentifier();
+ if (realmContextInstance != null && !realmContextInstance.isUnsatisfied())
{
Review Comment:
There are some tests that are not quarkus tests or not marked as quarkus
tests have this as null. I refactored all tests to either use Quarkus test or
use mock properly, and now i don't need this check anymore. I also removed
those constructer which seems only used by test which is not needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
