XN137 commented on code in PR #1663:
URL: https://github.com/apache/polaris/pull/1663#discussion_r2104607933
##########
api/iceberg-service/src/main/java/org/apache/polaris/service/types/NotificationType.java:
##########
@@ -84,9 +83,9 @@ public static Optional<NotificationType> lookupByName(String
name) {
return Optional.empty();
}
- for (NotificationType NotificationType : NotificationType.values()) {
- if (name.toUpperCase(Locale.ROOT).equals(NotificationType.name())) {
- return Optional.of(NotificationType);
+ for (NotificationType notificationType : NotificationType.values()) {
Review Comment:
the `lookupByName` method seems completely unused, so we could also just
remove it instead afaict.
same applies to the `displayName` field (whose value is always the same as
`name()`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
