eric-maynard commented on code in PR #1663: URL: https://github.com/apache/polaris/pull/1663#discussion_r2104782845
########## codestyle/errorprone-rules.properties: ########## @@ -227,6 +227,12 @@ UseCorrectAssertInTests=ERROR ConstantPatternCompile=ERROR # Variables initialized with Pattern#compile calls on constants can be constants +ObjectsHashCodePrimitive=ERROR +# Objects.hashCode(Object o) should not be passed a primitive value + +OptionalMapToOptional=ERROR +# Mapping to another Optional will yield a nested Optional. Did you mean flatMap? Review Comment: This is the only one I'm not so sure about. The bug you found looks real to me, but this is a legit pattern and I'm a bit wary of disallowing it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
