singhpk234 commented on code in PR #1589: URL: https://github.com/apache/polaris/pull/1589#discussion_r2103653186
########## quarkus/distribution/bin/server: ########## @@ -0,0 +1,22 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" +cd "${SCRIPT_DIR}/../server" || exit +java -jar quarkus-run.jar "$@" Review Comment: [minor] new line ########## quarkus/distribution/README.md: ########## @@ -0,0 +1,73 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Apache Polaris Distribution + +This distribution contains both the Polaris Server and Admin Tool. + +## Prerequisites + +- Java SE 21 or higher Review Comment: I think we just say 21 here, please ref thread here : https://github.com/apache/polaris/pull/1517#discussion_r2081932271 ########## quarkus/distribution/bin/admin: ########## @@ -16,24 +16,7 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -# - -# Linux Quarkus fast-jar run script for Apache Polaris - -set -e - -script_dir="$(dirname "$0")" - -if [ -z "$JAVA_HOME" ] ; then - JAVACMD="`\\unset -f command; \\command -v java`" -else - JAVACMD="$JAVA_HOME/bin/java" -fi - -if [ ! -x "$JAVACMD" ] ; then - echo "The JAVA_HOME environment variable is not defined correctly," >&2 - echo "this environment variable is needed to run this program." >&2 - exit 1 -fi -exec "${JAVACMD}" -jar "${script_dir}/quarkus-run.jar" $@ +SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" +cd "${SCRIPT_DIR}/../admin" || exit +java -jar quarkus-run.jar "$@" Review Comment: [minor] new line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
