flyrain commented on code in PR #1589: URL: https://github.com/apache/polaris/pull/1589#discussion_r2105363255
########## quarkus/server/build.gradle.kts: ########## @@ -84,78 +79,13 @@ tasks.named<QuarkusRun>("quarkusRun") { listOf("-Dpolaris.bootstrap.credentials=POLARIS,root,secret", "-Dquarkus.console.color=true") } -distributions { - main { - contents { - from(runScript) - from(project.layout.buildDirectory.dir("quarkus-app")) - from("distribution/NOTICE") - from("distribution/LICENSE") - from("distribution/README.md") - from("distribution/DISCLAIMER") - } - } -} - val quarkusBuild = tasks.named<QuarkusBuild>("quarkusBuild") -val distTar = - tasks.named<Tar>("distTar") { - dependsOn(quarkusBuild) - inputs.files(runScript) - compression = Compression.GZIP - } - -val distZip = - tasks.named<Zip>("distZip") { - dependsOn(quarkusBuild) - inputs.files(runScript) - } - -val digestDistTar = - tasks.register<GenerateDigest>("digestDistTar") { - description = "Generate the distribution tar digest" - mustRunAfter(distTar) - file.set { distTar.get().archiveFile.get().asFile } - } - -val digestDistZip = - tasks.register<GenerateDigest>("digestDistZip") { - description = "Generate the distribution zip digest" - mustRunAfter(distZip) - file.set { distZip.get().archiveFile.get().asFile } - } - -distTar.configure { finalizedBy(digestDistTar) } - -distZip.configure { finalizedBy(digestDistZip) } - -if (project.hasProperty("release") || project.hasProperty("signArtifacts")) { - signing { - sign(distTar.get()) - sign(distZip.get()) - } -} - // Expose runnable jar via quarkusRunner configuration for integration-tests that require the // server. artifacts { add(quarkusRunner.name, provider { quarkusBuild.get().fastJar.resolve("quarkus-run.jar") }) { builtBy(quarkusBuild) } - add(distributionTar.name, provider { distTar.get().archiveFile }) { builtBy(distTar) } - add(distributionTar.name, provider { digestDistTar.get().outputFile }) { builtBy(digestDistTar) } - add(distributionZip.name, provider { distZip.get().archiveFile }) { builtBy(distZip) } - add(distributionZip.name, provider { digestDistZip.get().outputFile }) { builtBy(digestDistZip) } -} - -afterEvaluate { - publishing { - publications { - named<MavenPublication>("maven") { - artifact(distTar.get().archiveFile) { builtBy(distTar) } - artifact(distZip.get().archiveFile) { builtBy(distZip) } - } - } - } + add("distributionElements", layout.buildDirectory.dir("quarkus-app")) { builtBy("quarkusBuild") } Review Comment: I'm OK with it. Any concern about the file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org