dimas-b commented on code in PR #1661:
URL: https://github.com/apache/polaris/pull/1661#discussion_r2105063289
##########
service/common/src/main/java/org/apache/polaris/service/auth/LocalRSAKeyProvider.java:
##########
@@ -48,12 +76,7 @@ public LocalRSAKeyProvider(Path publicKeyFileLocation, Path
privateKeyFileLocati
*/
@Override
public PublicKey getPublicKey() {
- try {
- return PemUtils.readPublicKeyFromFile(publicKeyFileLocation, "RSA");
- } catch (IOException e) {
- LOGGER.error("Unable to read public key from file {}",
publicKeyFileLocation, e);
- throw new RuntimeException("Unable to read public key from file " +
publicKeyFileLocation, e);
- }
+ return publicKey;
Review Comment:
This change will require server restarts for key rotation. I'm not sure if
on-the-fly key rotation was envisioned as a supported use case before, but it
might be worth flagging this behaviour change for visibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
