dimas-b commented on code in PR #1661:
URL: https://github.com/apache/polaris/pull/1661#discussion_r2107583360
##########
service/common/src/main/java/org/apache/polaris/service/auth/LocalRSAKeyProvider.java:
##########
@@ -48,12 +76,7 @@ public LocalRSAKeyProvider(Path publicKeyFileLocation, Path
privateKeyFileLocati
*/
@Override
public PublicKey getPublicKey() {
- try {
- return PemUtils.readPublicKeyFromFile(publicKeyFileLocation, "RSA");
- } catch (IOException e) {
- LOGGER.error("Unable to read public key from file {}",
publicKeyFileLocation, e);
- throw new RuntimeException("Unable to read public key from file " +
publicKeyFileLocation, e);
- }
+ return publicKey;
Review Comment:
I'm not saying the old code was perfect, but I sense that it might have had
a purpose :thinking:
@collado-mike WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
