flyrain commented on code in PR #1707:
URL: https://github.com/apache/polaris/pull/1707#discussion_r2112515712
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/EclipseLinkProductionReadinessChecks.java:
##########
@@ -36,7 +37,14 @@ public class EclipseLinkProductionReadinessChecks {
LoggerFactory.getLogger(EclipseLinkProductionReadinessChecks.class);
@Produces
- public ProductionReadinessCheck checkJdbcUrl(EclipseLinkConfiguration
eclipseLinkConfiguration) {
+ public ProductionReadinessCheck checkJdbcUrl(
Review Comment:
Minor: can we change the method name to something like `checkEclipseLink()`.
I think the current name is a bit confusing, as we have both jdbc impl. and
eclipseLink impl. Here, we only care about the eclipse link one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
