dimas-b commented on code in PR #1707:
URL: https://github.com/apache/polaris/pull/1707#discussion_r2112747494
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/EclipseLinkProductionReadinessChecks.java:
##########
@@ -36,7 +37,14 @@ public class EclipseLinkProductionReadinessChecks {
LoggerFactory.getLogger(EclipseLinkProductionReadinessChecks.class);
@Produces
- public ProductionReadinessCheck checkJdbcUrl(EclipseLinkConfiguration
eclipseLinkConfiguration) {
+ public ProductionReadinessCheck checkJdbcUrl(
+ EclipseLinkConfiguration eclipseLinkConfiguration,
+ @ConfigProperty(name = "polaris.persistence.type") String
persistenceType) {
+ // This check should only be applicable when persistence uses EclipseLink.
+ if (!("eclipse-link".equalsIgnoreCase(persistenceType))) {
Review Comment:
It might be more maintainable to inject a `MetaStoreManagerFactory` and do
`instanceof EclipseLinkPolarisMetaStoreManagerFactory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
