eric-maynard commented on code in PR #1758:
URL: https://github.com/apache/polaris/pull/1758#discussion_r2121609783


##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##########
@@ -43,6 +43,10 @@ public interface PolarisConfigurationStore {
    * @param configName the name of the configuration key to check
    * @return the current value set for the configuration key or null if not set
    * @param <T> the type of the configuration value
+   *     <p>This function needs to be used with caution, it can not be called 
outside of active
+   *     request scope, such as background tasks (TaskExecutor). Please use 
the function
+   *     getConfiguration(String realm, String configName) to get the 
configuration value in a more
+   *     robust way.

Review Comment:
   Should we just get rid of this function then? I know it's used in a lot of 
places but it sounds unsafe to use.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to