dimas-b commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2124466043
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##########
@@ -403,6 +404,20 @@ boolean hasChildren(
long catalogId,
long parentId);
+ /**
+ * Check if the specified IcebergTableLikeEntity has any same-namespace
siblings which share a
+ * location
+ *
+ * @param callContext the polaris call context
+ * @param parentId the parent entity to look for duplicates inside
+ * @param location the location to check for overlaps against
+ * @return Optional.of(Optional.of(location)) if the parent entity has
children,
+ * Optional.of(Optional.empty()) if not, and Optional.empty() if the
metastore doesn't support
+ * this operation
+ */
+ Optional<Optional<String>> hasOverlappingSiblings(
+ @Nonnull PolarisCallContext callContext, long parentId, String location);
Review Comment:
Sorry, I missed out on `getDefaultBaseLocation()` in `CatalogEntity`.
However, I believe the new API method should be clear about the relationship
of `CatalogEntity.getDefaultBaseLocation()` and the `location` method parameter.
Also, re: `getDefaultBaseLocation()` ... since it's "default", is there a
possibility it's overridden? Is there a possibility a catalog has other,
non-default locations that need to be checked for overlaps?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
