eric-maynard commented on code in PR #1686:
URL: https://github.com/apache/polaris/pull/1686#discussion_r2122634939


##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatabaseType.java:
##########
@@ -44,6 +44,6 @@ public static DatabaseType fromDisplayName(String 
displayName) {
   }
 
   public String getInitScriptResource() {
-    return String.format("%s/schema-v1.sql", this.getDisplayName());
+    return String.format("%s/schema-v2.sql", this.getDisplayName());

Review Comment:
   0.10 is an "experimental" release, and even if it wasn't I'm not sure what 
guarantees we make about backwards compatibility of persistence from one 
version to the next. Further, it seems like it will "just work" with old 
versions as they just won't select the new column. Is there any user-visible 
change?
   
   Beyond this PR, we should probably define that and create a doc that maps 
between these schema files and releases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to