flyrain commented on code in PR #1830:
URL: https://github.com/apache/polaris/pull/1830#discussion_r2133968992
##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -151,13 +151,16 @@ tasks.register("checkNoDisallowedImports") {
tasks.named("check") { dependsOn("checkNoDisallowedImports") }
tasks.register<ShadowJar>("createPolarisSparkJar") {
- archiveClassifier = null
- archiveBaseName =
-
"polaris-iceberg-${icebergVersion}-spark-runtime-${sparkMajorVersion}_${scalaVersion}"
+ archiveClassifier = "bundle"
Review Comment:
Users can open up the jar file to figure out the embedded Iceberg version.
But my concern is that a lot of users don't know that or couldn't do that
easily. I think it's still valuable to provide the iceberg versions as it's
embedded. Unless we figure out a way to not embed it.
> I don't think it is a good idea to have iceberg version as project name,
since the iceberg version might gets updated more frequently.
We need to release a new version for this plugin every time we update the
embedded Iceberg version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
