flyrain commented on code in PR #1830:
URL: https://github.com/apache/polaris/pull/1830#discussion_r2134806912
##########
plugins/spark/v3.5/spark/build.gradle.kts:
##########
@@ -151,13 +151,16 @@ tasks.register("checkNoDisallowedImports") {
tasks.named("check") { dependsOn("checkNoDisallowedImports") }
tasks.register<ShadowJar>("createPolarisSparkJar") {
- archiveClassifier = null
- archiveBaseName =
-
"polaris-iceberg-${icebergVersion}-spark-runtime-${sparkMajorVersion}_${scalaVersion}"
+ archiveClassifier = "bundle"
Review Comment:
>only need to release a new version every time we do a release
+1
> if we we have it in the project name, then the project name has to be
updated every time the iceberg version is updated
I don't think we need to do that.
>i hope in long term, we don't have to ship iceberg runtime in the bundle,
and I think we should definitely have a doc/webpage somewhere to doc the
compatible iceberg version regardless whether it is in the name or not.
Thanks for the investigation! Let's doc it first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
