eric-maynard commented on code in PR #1838:
URL: https://github.com/apache/polaris/pull/1838#discussion_r2139122216
##########
persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkStore.java:
##########
@@ -294,14 +295,25 @@ List<ModelEntity> lookupFullEntitiesActive(
// Currently check against ENTITIES not joining with ENTITIES_ACTIVE
String hql =
- "SELECT m from ModelEntity m where m.catalogId=:catalogId and
m.parentId=:parentId and m.typeCode=:typeCode";
+ "SELECT m from ModelEntity m where"
+ + " m.catalogId=:catalogId and m.parentId=:parentId and
m.typeCode=:typeCode and m.id > :tokenId";
+
+ long tokenId = -1;
Review Comment:
There used to be a constant for this in `EntityIdPageToken`; putting a magic
number here is not a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
