eric-maynard commented on code in PR #1838:
URL: https://github.com/apache/polaris/pull/1838#discussion_r2139124237
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -217,6 +217,7 @@ public static void enforceFeatureEnabledOrThrow(
public static final PolarisConfiguration<Boolean> LIST_PAGINATION_ENABLED =
PolarisConfiguration.<Boolean>builder()
.key("LIST_PAGINATION_ENABLED")
+ .catalogConfig("polaris.config.list-pagination-enabled")
Review Comment:
Unless you change the check in `IcebergCatalog`, you're just adding a flag
that does nothing here
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -217,6 +217,7 @@ public static void enforceFeatureEnabledOrThrow(
public static final PolarisConfiguration<Boolean> LIST_PAGINATION_ENABLED =
PolarisConfiguration.<Boolean>builder()
.key("LIST_PAGINATION_ENABLED")
+ .catalogConfig("polaris.config.list-pagination-enabled")
Review Comment:
Unless you change the check in `IcebergCatalog`, you're adding a flag that
does nothing here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
