dimas-b commented on code in PR #1838: URL: https://github.com/apache/polaris/pull/1838#discussion_r2140591476
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageRequest.java: ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.persistence.pagination; + +import static com.google.common.base.Preconditions.checkState; + +import jakarta.annotation.Nullable; + +/** A wrapper for pagination information passed in as part of a request. */ +public class PageRequest { + private final @Nullable String innerPageToken; + private final int pageSize; + + PageRequest(@Nullable String innerPageToken, int pageSize) { + this.innerPageToken = innerPageToken; + this.pageSize = pageSize; + } + + /** Represents a non-paginated request. */ + public static PageRequest readEverything() { + return new PageRequest(null, -1); + } + + /** Represents a request to start paginating with a particular page size. */ + public static PageRequest firstPage(int limit) { Review Comment: This is now `PageToken.fromLimit()` (same name as before). The use case is for handling initial paged requests where a size is provided, but a token in not. For API-based calls that is taken care of by the `decode()` method. This method is a convenience entry point for internal calls. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
