eric-maynard commented on code in PR #1838:
URL: https://github.com/apache/polaris/pull/1838#discussion_r2139131910
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/pagination/PageToken.java:
##########
@@ -18,82 +18,85 @@
*/
package org.apache.polaris.core.persistence.pagination;
-import java.util.List;
-import java.util.Objects;
+import static com.google.common.base.Preconditions.checkState;
-/**
- * Represents a page token that can be used by operations like `listTables`.
Clients that specify a
- * `pageSize` (or a `pageToken`) may receive a `next-page-token` in the
response, the content of
- * which is a serialized PageToken.
- *
- * <p>By providing that in the next query's `pageToken`, the client can resume
listing where they
- * left off. If the client provides a `pageToken` or `pageSize` but
`next-page-token` is null in the
- * response, that means there is no more data to read.
- */
-public abstract class PageToken {
+import jakarta.annotation.Nullable;
- /** Build a new PageToken that reads everything */
- public static PageToken readEverything() {
- return build(null, null);
- }
+/** A wrapper for pagination information passed in as part of a request. */
Review Comment:
Why only a request? Isn't the response field called `next-page-token`? Is
that not a PageToken?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
