gh-yzou commented on code in PR #1897:
URL: https://github.com/apache/polaris/pull/1897#discussion_r2145569851
##########
.github/workflows/gradle.yml:
##########
@@ -33,65 +33,111 @@ on:
branches: [ "main" ]
jobs:
- build:
+ style-checks:
+ name: Code Style & Publishing Checks
runs-on: ubuntu-latest
permissions:
contents: read
-
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- - name: Set up JDK 21
+ - name: Set up JDK 23
Review Comment:
i think the ci before runs whole check, build, and tests on JDK 21 because
Polaris is currently guarantee the compatibility with java 21, and then we are
only doing selected check with java 23.
If we just update the JDK version to 23, that means we will loose the test
coverage for 21, right? if the intension of this PR is to just split the ci
into multiple jobs, can we keep the java 21 setup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
