gh-yzou commented on code in PR #1897:
URL: https://github.com/apache/polaris/pull/1897#discussion_r2145793957
##########
.github/workflows/gradle.yml:
##########
@@ -33,65 +33,111 @@ on:
branches: [ "main" ]
jobs:
- build:
+ style-checks:
+ name: Code Style & Publishing Checks
runs-on: ubuntu-latest
permissions:
contents: read
-
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- - name: Set up JDK 21
+ - name: Set up JDK 23
Review Comment:
The original CI have the following coverage for 21
```
run: ./gradlew --continue check
```
which I believe runs all tests, and on 23 it only does compilation and
integration tests. I don't think we need to introduce a test matrix in the
current PR, can we retain the full coverage for 21, and keep the thing coverage
for 23 in this PR?
and if we really want to also introduce full coverage for java 23 we can do
it in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
