adutra commented on code in PR #1857: URL: https://github.com/apache/polaris/pull/1857#discussion_r2150513660
########## site/content/in-dev/unreleased/polaris-spark-client.md: ########## @@ -128,3 +128,21 @@ The Polaris Spark client has the following functionality limitations: 3) Rename a Delta table is not supported. 4) ALTER TABLE ... SET LOCATION is not supported for DELTA table. 5) For other non-Iceberg tables like csv, it is not supported. + +## Iceberg Spark Client compatibility with Polaris Spark Client +The Polaris Spark client today is not designed to be used with Iceberg Spark client together. In other words, Review Comment: Just for reference, Dremio Auth Manager took the opposite approach: https://github.com/dremio/iceberg-auth-manager/blob/9cc9459ed5cd0ad30a9c08143c98d8b0c620e3a2/oauth2/runtime/build.gradle.kts#L62-L71 > I think we really like the idea that we can ship a single jar that a user can use to enable this functionality. Imho for users that can fetch from Maven Central, fetching one or two artifacts really doesn't make any difference. And for the adepts of manual jar downloads, indeed they'd need to download one more jar; but how many jars are they downloading already :-) Anyways, If you all want to keep the uber-jar approach around, who am I to disagree. > Now both of these things I don't think are necessarily related or blocking 1.0. Well, yes and no: as you pointed out, Spark/Ivy does not recognize classifiers, so if we go with the big-jar as the default classifier, this means that the "slim jar" artifact will have to have a different artifact ID. > Do you think it would be ok that if we deliver both the bundle and non-bundled That's definitely better, yes. Maybe could we prepare for that and rename this artifact's ID to `polaris-spark-catalog-plugin-bundle` as suggested above? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
