flyrain commented on code in PR #1857:
URL: https://github.com/apache/polaris/pull/1857#discussion_r2150691584


##########
site/content/in-dev/unreleased/polaris-spark-client.md:
##########
@@ -128,3 +128,21 @@ The Polaris Spark client has the following functionality 
limitations:
 3) Rename a Delta table is not supported.
 4) ALTER TABLE ... SET LOCATION is not supported for DELTA table.
 5) For other non-Iceberg tables like csv, it is not supported.
+
+## Iceberg Spark Client compatibility with Polaris Spark Client
+The Polaris Spark client today is not designed to be used with Iceberg Spark 
client together. In other words,

Review Comment:
   I've tested it locally with Spark 3.5.6 against apache maven. The package 
option works well for me. I don't think it's a blocker after this test. Here is 
the command I used for test:
   ```
   bin/spark-shell \
   --packages 
org.apache.polaris:polaris-spark-3.5_2.12:1.1.0-incubating-SNAPSHOT,io.delta:delta-spark_2.12:3.3.1
 \
   --repositories https://repository.apache.org/content/groups/snapshots/ \
   --conf 
spark.sql.extensions=org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions,io.delta.sql.DeltaSparkSessionExtension
 \
   --conf 
spark.sql.catalog.spark_catalog=org.apache.spark.sql.delta.catalog.DeltaCatalog 
\
   --conf spark.sql.catalog.polaris.warehouse=manual_spark \
   --conf 
spark.sql.catalog.polaris.header.X-Iceberg-Access-Delegation=vended-credentials 
\
   --conf spark.sql.catalog.polaris=org.apache.polaris.spark.SparkCatalog \
   --conf spark.sql.catalog.polaris.uri=http://127.0.0.1:8181/api/catalog \
   --conf spark.sql.catalog.polaris.credential='root:secret' \
   --conf spark.sql.catalog.polaris.scope='PRINCIPAL_ROLE:ALL' \
   --conf spark.sql.catalog.polaris.token-refresh-enabled=true
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to