pingtimeout commented on code in PR #21:
URL: https://github.com/apache/polaris-tools/pull/21#discussion_r2151781624
##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/parameters/DatasetParameters.scala:
##########
@@ -54,7 +54,7 @@ case class DatasetParameters(
numViewProperties: Int
) {
val nAryTree: NAryTreeBuilder = NAryTreeBuilder(nsWidth, nsDepth)
- private val maxPossibleTables = nAryTree.numberOfLastLevelElements *
numTablesPerNs
+ val maxPossibleTables = nAryTree.numberOfLastLevelElements * numTablesPerNs
Review Comment:
That's an interesting idea. Let's defer this to a future PR as we can
improve the code incrementally.
The benchmarks config currently uses `dataset.tree` as the prefix for the
tree-related parameters. We could totally introduce a new dataset shape like:
```hocon
dataset {
tree {
...
}
flat {
...
}
}
```
I think Russel mentioned this shape a long time ago. So that would make
total sense, especially if you are already using it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
