eric-maynard commented on code in PR #21:
URL: https://github.com/apache/polaris-tools/pull/21#discussion_r2152567384


##########
benchmarks/src/gatling/scala/org/apache/polaris/benchmarks/parameters/DatasetParameters.scala:
##########
@@ -54,7 +54,7 @@ case class DatasetParameters(
     numViewProperties: Int
 ) {
   val nAryTree: NAryTreeBuilder = NAryTreeBuilder(nsWidth, nsDepth)
-  private val maxPossibleTables = nAryTree.numberOfLastLevelElements * 
numTablesPerNs
+  val maxPossibleTables = nAryTree.numberOfLastLevelElements * numTablesPerNs

Review Comment:
   Yeah, we can defer that. Right now what I do is just make the ns width as 1 
and then it becomes naturally flat :)
   
   I needed to use this shape for the benchmark in [this 
PR](https://github.com/apache/polaris/pull/1686) since I cared specifically 
about many tables in one ns



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to