gh-yzou commented on code in PR #1897:
URL: https://github.com/apache/polaris/pull/1897#discussion_r2152940037
##########
.github/workflows/gradle.yml:
##########
@@ -33,65 +33,111 @@ on:
branches: [ "main" ]
jobs:
- build:
+ style-checks:
+ name: Code Style & Publishing Checks
runs-on: ubuntu-latest
permissions:
contents: read
-
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
- - name: Set up JDK 21
+ - name: Set up JDK 23
Review Comment:
sorry, for the confusion. i don't really mean still run ./gradlew --continue
check. what i mean is when we are breaking it into jobs, make sure the tasks
runs on 21 still provides the fully test coverage, include unit test, initTest,
style check, publishToMaven etc. For 23 it can remain just have one job with
coverage for integration test.
However, it seems we are now removing the coverage on 23 now because 23 is
going to be end of like, which i think should be fine.
If we want to further breakdown the job runs with 21 to more jobs, i am also
fine with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
