gh-yzou commented on code in PR #1908:
URL: https://github.com/apache/polaris/pull/1908#discussion_r2159742321
##########
codestyle/checkstyle.xml:
##########
@@ -26,6 +26,10 @@
<property name="severity" value="warning"/>
<property name="fileExtensions" value="java, properties, xml"/>
+ <module name="SuppressionFilter">
+ <property name="file" value="${checkstyle.suppression.file}"/>
Review Comment:
it is not the same, actually line 41-42 is not doing anything, the config
says look for config `org.checkstyle.google.suppressionfilter.config`, which i
don't think we configure it anywhere in our project, if not configured, use
file checkstyle-suppressions.xml, which we do not have it anywhere in the
project also, the check style job doesn't fail, because it sets optional to
true.
Now since we do have the suppressions file, i made it non-optional, and
removed the other configuration. One thing i did notice here is that if i just
use the relative path regarding to root project path, gradlew build seems not
able to found the path, the recommended way seems using the config, and then
get the absolute path, which is the way i am going with now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
