gh-yzou commented on code in PR #1908: URL: https://github.com/apache/polaris/pull/1908#discussion_r2162434437
########## codestyle/checkstyle_suppressions.xml: ########## @@ -0,0 +1,32 @@ +<?xml version="1.0"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> +<!DOCTYPE suppressions PUBLIC + "-//Puppy Crawl//DTD Suppressions Configuration 1.2//EN" + "https://checkstyle.org/dtds/suppressions_1_2.dtd";> + +<suppressions> + <!-- + Suppress IllegalImport in all files under plugins/spark/v3.5/spark. + The spark client relies on the shaded libraries from iceberg-spark-runtime, + and therefore uses imports like org.apache.iceberg.shaded.* in the code, + which is intended. + --> + <suppress checks="IllegalImport" files="plugins/spark/v3.5/spark/.*"/> Review Comment: Moved the suppress config to spark client side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
