dimas-b commented on code in PR #1988: URL: https://github.com/apache/polaris/pull/1988#discussion_r2180488604
########## persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java: ########## @@ -100,17 +99,18 @@ private void initializeForRealm( DatasourceOperations datasourceOperations, RealmContext realmContext, RootCredentialsSet rootCredentialsSet) { + String realmId = realmContext.getRealmIdentifier(); sessionSupplierMap.put( - realmContext.getRealmIdentifier(), Review Comment: Sorry, I do not really see any major runtime difference before/after this change. Could you add comments or clarify what the change is supposed to do in the PR description? It has a link to another PR, but the linked page has a rather long discussion thread... It would be nice to describe specifically what this PR fixes, please. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org