adnanhemani commented on code in PR #1988:
URL: https://github.com/apache/polaris/pull/1988#discussion_r2184221167
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -100,17 +99,18 @@ private void initializeForRealm(
DatasourceOperations datasourceOperations,
RealmContext realmContext,
RootCredentialsSet rootCredentialsSet) {
+ String realmId = realmContext.getRealmIdentifier();
sessionSupplierMap.put(
- realmContext.getRealmIdentifier(),
+ realmId,
() ->
new JdbcBasePersistenceImpl(
datasourceOperations,
- secretsGenerator(realmContext, rootCredentialsSet),
+ secretsGenerator(realmId, rootCredentialsSet),
Review Comment:
Added!
##########
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -100,17 +99,18 @@ private void initializeForRealm(
DatasourceOperations datasourceOperations,
RealmContext realmContext,
RootCredentialsSet rootCredentialsSet) {
+ String realmId = realmContext.getRealmIdentifier();
sessionSupplierMap.put(
- realmContext.getRealmIdentifier(),
Review Comment:
I've added more details to the PR description and added a comment as well!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
