dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2180905497
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespace,
Set<String> properties)
.map(PolarisEntity::new)
.orElse(null);
if (returnedEntity == null) {
- throw new RuntimeException("Concurrent modification of namespace: " +
namespace);
+ throw new CommitFailedException("Concurrent modification of namespace:
%s", namespace);
Review Comment:
IMHO, `CommitFailedException` is too generic to be used for reporting
conflicts.
I'd prefer to have a Polaris-specific exception class specifically for
reporting conflicts and mapping them to 409 at the REST API layer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
