dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2183123442
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespace,
Set<String> properties)
.map(PolarisEntity::new)
.orElse(null);
if (returnedEntity == null) {
- throw new RuntimeException("Concurrent modification of namespace: " +
namespace);
+ throw new CommitFailedException("Concurrent modification of namespace:
%s", namespace);
Review Comment:
I think having a polaris-specific exception for this case will simplify
maintenance and allow fine-tuning response... so please so.
As for the name, I'd propose
`org.apache.polaris.core.exceptions.CommitConflictException` extending
`PolarisException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
