eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2183969935
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##########
@@ -86,18 +102,32 @@ public static List<PolarisConfiguration<?>>
getAllConfigurations() {
@SuppressWarnings("unchecked")
protected PolarisConfiguration(
String key,
+ Set<String> legacyKeys,
String description,
T defaultValue,
Optional<String> catalogConfig,
Optional<String> catalogConfigUnsafe) {
this.key = key;
+ this.legacyKeys = legacyKeys;
this.description = description;
this.defaultValue = defaultValue;
this.catalogConfigImpl = catalogConfig;
this.catalogConfigUnsafeImpl = catalogConfigUnsafe;
this.typ = (Class<T>) defaultValue.getClass();
}
+ public boolean hasLegacyKeys() {
+ return !legacyKeys.isEmpty();
+ }
+
+ public String legacyKeys() {
Review Comment:
I would not expect this to return a `String` either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
