eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2190623796
##########
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##########
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
*/
default <T> @Nonnull T getConfiguration(
@Nonnull RealmContext realmContext, PolarisConfiguration<T> config) {
- T result = getConfiguration(realmContext, config.key, config.defaultValue);
+ T result = getConfiguration(realmContext, config.key);
+
+ if (result == null && config.hasLegacyKeys()) {
+ for (String legacyKey : config.legacyKeys) {
+ result = getConfiguration(realmContext, legacyKey);
+ if (result != null) {
+ LOGGER.warn(
+ "Legacy configuration key '{}' is in use. Please use '{}'
instead.",
+ legacyKey,
+ config.key);
+ break;
Review Comment:
> 1. If multiple legacy keys really are in use, we should want to log for
each of them
Yes, I'm referring to the logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
