pavibhai commented on code in PR #1424:
URL: https://github.com/apache/polaris/pull/1424#discussion_r2193493293


##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -298,4 +298,12 @@ public static void enforceFeatureEnabledOrThrow(
                   + "in their snapshot summary")
           .defaultValue(false)
           .buildFeatureConfiguration();
+
+  public static final FeatureConfiguration<Boolean> ENABLE_KMS_SUPPORT_FOR_S3 =

Review Comment:
   Yeah, I do have a patch for this that we are using internally. Let me see if 
@fivetran-ashokborra is still working on this, otherwise I can propose a change.
   
   The steps are essentially as follows:
   * Identify the buckets from the paths
   * Use the bucket metadata to determine the bucket key configured
   * Include that into the content policy generated for KMS resources



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to