pavibhai commented on code in PR #1424: URL: https://github.com/apache/polaris/pull/1424#discussion_r2232260043
########## polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java: ########## @@ -298,4 +298,12 @@ public static void enforceFeatureEnabledOrThrow( + "in their snapshot summary") .defaultValue(false) .buildFeatureConfiguration(); + + public static final FeatureConfiguration<Boolean> ENABLE_KMS_SUPPORT_FOR_S3 = Review Comment: Sure @fivetran-ashokborra let me drop a note shortly on what we are thinking as the approach here. ########## polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java: ########## @@ -298,4 +298,12 @@ public static void enforceFeatureEnabledOrThrow( + "in their snapshot summary") .defaultValue(false) .buildFeatureConfiguration(); + + public static final FeatureConfiguration<Boolean> ENABLE_KMS_SUPPORT_FOR_S3 = Review Comment: Sure @fivetran-ashokborra let me drop a note shortly on what we are thinking as the approach here, we can take it from there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org